Fix with meta flag for analytics queries #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westwooo
force-pushed
the
with_meta
branch
4 times, most recently
from
997e0b5 to
9ef701a
Compare
chvck
reviewed
Dec 11, 2024
src/cli/analytics.rs
Outdated
| inner: vec![], | ||
| })?; | ||
|
|
||
| let (start, _) = from_utf8(&epilog).unwrap().split_at(epilog.len() - 1); |
There was a problem hiding this comment.
Is there no way that we can create the nu value without manually creating a JSON value?
chvck
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #556
This change means that the results of an analytics query will not be streamed when the with-meta flag is used, this behaviour will need to be documented. It would be possible to have the meta returned and still stream the queries, but this has two issues: