Allow username and password to be passed into register with flags #401
Conversation
Westwooo
force-pushed
the
flags_for_creds_cbenv_register
branch
from
dc80785
to
2a66084
Compare
Westwooo
force-pushed
the
flags_for_creds_cbenv_register
branch
from
2a66084
to
a344428
Compare
Westwooo
force-pushed
the
flags_for_creds_cbenv_register
branch
from
a344428
to
ca1259a
Compare
| let password = password_flag.map_or_else( | ||
| || match rpassword::prompt_password("Password: ") { | ||
| Ok(p) => { | ||
| if p.is_empty() { |
There was a problem hiding this comment.
Doesn't look like the original code had this check, is it needed?
I assume there could be cases where we don't want to include a password at all (e.g. when using certs). Does this check get avoided for those cases?
There was a problem hiding this comment.
The original code didn't have this check as I thought that prompt_password returned an error on am empty password, but it does not.
Even when using certs cbshell needs the username and password to perform any doc ops. Also when we register a cluster through the config file we return an error if there is no username and password, so I think it should be the same when registering a cluster through this command.
The other place this is used is when creating credentials, where we obviously need a username and password. I think if there was something that used wither certs or username/password it'd be the responsibility of the caller to call this func if they require a username and password, and don't if a cert has been supplied.
There was a problem hiding this comment.
Thanks for the context, makes sense.
By default the
cb-env registercommand prompts for the user name and password to be entered after running the command, allowing the password to be hidden. We should support passing the username and password in using flags to allow registering multiple clusters without having to repeatedly enter the same username and password.