Allow id to be an int in doc upsert #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chvck
reviewed
Aug 20, 2024
src/cli/doc_upsert.rs
Outdated
| @@ -164,7 +165,18 @@ pub(crate) fn run_kv_store_ops( | |||
| let mut content = None; | |||
| for (k, v) in val.iter() { | |||
| if k.clone() == id_column { | |||
| id = v.as_str().ok(); | |||
| id = match v { | |||
There was a problem hiding this comment.
Does this need applying to get too?
There was a problem hiding this comment.
No, get, remove and subdoc_get all use ids_from_input which works with ints.
Replace, upsert and insert all use this so are fine but import does need changing.
|
The commit message is a bit misleading as i think this applies to all kv store commnands? |
Westwooo
force-pushed
the
doc_upsert_int_ids
branch
from
cb58c2f
to
8a25d54
Compare
|
Found it a bit confusing to have run_kv_store_ops in the Upsert CLI. Would it be better to have a KV_Doc commons with all these operations ? |
It could be, will raise an issue to look into refactoring this |
Matt-Woz
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.