-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ip command #376
Allow ip command #376
Conversation
a81ed02
to
2b7ab17
Compare
src/cli/allow_ip.rs
Outdated
} | ||
|
||
fn format_ip_address(ip_address: String) -> String { | ||
if !ip_address.ends_with("/32") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ip address can't be any other format can it? Just checking that we aren't blocking some usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addresses required a subnet mask, and if not given the UI defaults to try and use '/32', so I've changed this to behave the same.
ef38752
to
e036f8c
Compare
e4ca4a4
to
8acab9b
Compare
8acab9b
to
c903680
Compare
Fails in loop if the current project is not set. |
That's expected, unless passing in a projects with the --project flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
No description provided.