SDKQE-3441: Add ability to add external links to Capella Columnar clu… #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brett19
reviewed
Oct 3, 2024
utils/capellacontrol/controller.go
Outdated
| tenantID, projectID, columnarID string, | ||
| req *ColumnarQueryRequest, | ||
| ) error { | ||
| path := fmt.Sprintf("/v2/organizations/%s/projects/%s/instance/%s/proxy/query/service", tenantID, projectID, columnarID) |
There was a problem hiding this comment.
This looks like it proxies to the query service rather than the analytics service?
There was a problem hiding this comment.
Good point, I just took this from what the UI was calling which is interesting. It works either way turns out.
willbroadbelt
force-pushed
the
addColumnarLinksCmds
branch
from
9b786ce to
93f87b4
Compare
brett19
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sters