SDKQE-3419: Support load-sample buckets for cloud columnar and clusters #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brett19
requested changes
Sep 4, 2024
utils/capellacontrol/manager.go
Outdated
| @@ -62,7 +62,7 @@ func (m *Manager) WaitForClusterState( | |||
| continue | |||
| } | |||
|
|
|||
| break | |||
| return nil | |||
There was a problem hiding this comment.
Rather than having this function try and be a 'generic solution' for all types of clusters, we should probably modify this function to either take the type of cluster its dealing with as input, or alternatively have it perform both ListClusters and ListAllColumnars as part of a single loop. I think there are some edge-cases where it could fall into the wrong loop.
There was a problem hiding this comment.
Makes sense, it was a bit messy. I've added a columnar param and made into 1 for loop.
brett19
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.