Add support to collect server logs for capella clusters #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couch-Matt
approved these changes
May 14, 2024
brett19
requested changes
May 14, 2024
CosmicSaaurabh
force-pushed
the
collect-server-logs-for-capella-cluster
branch
2 times, most recently
from
7bf0eae to
027ddc4
Compare
brett19
reviewed
May 15, 2024
brett19
requested changes
May 15, 2024
| @@ -999,6 +1001,8 @@ var initCmd = &cobra.Command{ | |||
| flagCapellaPass, _ := cmd.Flags().GetString("capella-pass") | |||
| flagCapellaOid, _ := cmd.Flags().GetString("capella-oid") | |||
| flagCapellaOverrideToken, _ := cmd.Flags().GetString("capella-override-token") | |||
| flagCapellaInternalSupportToken, _ := cmd.Flags().GetString("capella-internal-support-token") | |||
| flagUploadServerLogsHostName, _ := cmd.Flags().GetString("upload-server-logs-host-name") | |||
There was a problem hiding this comment.
It looks like you've added flagUploadServerLogsHostName here, but I don't see it being used below.
CosmicSaaurabh
force-pushed
the
collect-server-logs-for-capella-cluster
branch
from
81c9f45 to
deb1d5b
Compare
CosmicSaaurabh
force-pushed
the
collect-server-logs-for-capella-cluster
branch
from
deb1d5b to
2f3c10d
Compare
brett19
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to collect server logs for capella clusters