CBG-3694: Improved logging for failed session auth #7081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrks
changed the title
torcolvin
previously approved these changes
Aug 19, 2024
gregns1
approved these changes
Aug 20, 2024
bbrks
added a commit
that referenced
this pull request
Sep 26, 2024
* Improve (session) TestLogin to cover happy path and basic session auth failure cases * Log warnings when we're unable to create a session for a user * Cover invalid sessions with logs * Switch to info log level
1 task
gregns1
pushed a commit
that referenced
this pull request
Oct 2, 2024
* CBG-3692: Improved logging for failed basic auth login (#7080) * Add test to cover disabled non-guest user * Add AuthenticateWithReason to User interface/impl * Use AuthenticateWithReason to populate better warning message on basic auth failure * Keep old message format * Coverage for incorrect password logging * Switch to info log level * Update auth/user.go Co-authored-by: Tor Colvin <[email protected]> --------- Co-authored-by: Tor Colvin <[email protected]> * CBG-3693: Improved logging for no-user/no auto-register case in JWT auth (#7082) * CBG-3694: Improved logging for failed session auth (#7081) * Improve (session) TestLogin to cover happy path and basic session auth failure cases * Log warnings when we're unable to create a session for a user * Cover invalid sessions with logs * Switch to info log level --------- Co-authored-by: Tor Colvin <[email protected]>
bbrks
added a commit
that referenced
this pull request
Oct 8, 2024
* CBG-3692: Improved logging for failed basic auth login (#7080) * Add test to cover disabled non-guest user * Add AuthenticateWithReason to User interface/impl * Use AuthenticateWithReason to populate better warning message on basic auth failure * Keep old message format * Coverage for incorrect password logging * Switch to info log level * Update auth/user.go Co-authored-by: Tor Colvin <[email protected]> --------- Co-authored-by: Tor Colvin <[email protected]> * CBG-3693: Improved logging for no-user/no auto-register case in JWT auth (#7082) * CBG-3694: Improved logging for failed session auth (#7081) * Improve (session) TestLogin to cover happy path and basic session auth failure cases * Log warnings when we're unable to create a session for a user * Cover invalid sessions with logs * Switch to info log level --------- Co-authored-by: Tor Colvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-3694
user.AuthenticateWithReason()Integration Tests