CBL-5181: Array Index API tests and adjustments #3330
Merged
+546
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasin
reviewed
Oct 3, 2024
| @@ -33,7 +35,7 @@ | |||
|
|
|||
| NS_ASSUME_NONNULL_BEGIN | |||
|
|
|||
| @interface CBLCollection () <CBLRemovableListenerToken> | |||
| @interface CBLCollection () <CBLRemovableListenerToken, CBLIndexableInternal> | |||
There was a problem hiding this comment.
I don't see a reason to create a protocol for CBLIndexableInternal as CBLCollection will not be used as CBLIndexableInternal type. I think you can just add a method indexesInfo in CBLCollection() directly.
pasin
requested changes
Oct 3, 2024
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| @protocol CBLIndexableInternal <CBLIndexable> |
There was a problem hiding this comment.
Don't need to create the protocol for this as the method can be put directly to CBLCollection Internal.
Also no need to have underscored prefix as this function will not be a public API.
pasin
approved these changes
Oct 4, 2024
| [NSException raise: NSInvalidArgumentException format: | ||
| @"Expressions cannot be empty "]; | ||
| @"Empty expressions is not allowed, use nil instead"]; |
There was a problem hiding this comment.
Can you add another validation for a single empty string ? We don't allow that to be set as well. See the updated API spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internalsection at the end of file forObjective-C/CBLCollection.mmindexesInfowhich is exactlycoll.indexes()but keeping all information for each index found, not only stripping the name out of itexpectExcepiontypo