feat: add a user-friendly message for AddrInUse error #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
seqre
approved these changes
Mar 7, 2025
| let result = crate::run(bootstrapper, &addr_port).await; | ||
| if let Err(error) = &result { | ||
| if let Some(user_friendly_error) = Self::get_user_friendly_error(error, &addr_port) { | ||
| eprintln!("{user_friendly_error}"); |
There was a problem hiding this comment.
If we handled a specific error, shouldn't we exit early here?
There was a problem hiding this comment.
I think (I might be wrong) that it still makes sense to print out the entire error structure anyways for debugging purposes. Also, this gives a chance to cleanup the stack with RAII as opposed to std::process::exit which terminates instantly.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227