Support "Remove Model" in Automatic Migration Generator #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soroushsrd
force-pushed
the
feature/remove-model-operation
branch
2 times, most recently
from
07eefc1 to
30ce2ef
Compare
Implement the ability to detect when a model has been removed from the codebase and generate appropriate migration operations. This includes: - Add RemoveModel variant to OperationInner enum in migrations.rs - Create RemoveModelBuilder for constructing remove operations - Implement make_remove_model_operation in migration_generator.rs - Update relevant utility functions to handle the new operation type - Add tests for the new functionality Fixes cot-rs#207
Soroushsrd
force-pushed
the
feature/remove-model-operation
branch
from
30ce2ef to
a9c7249
Compare
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
seqre
approved these changes
Mar 4, 2025
Merged
seqre
added a commit
that referenced
this pull request
Mar 4, 2025
* Add support for removing models in automatic migration generator Implement the ability to detect when a model has been removed from the codebase and generate appropriate migration operations. This includes: - Add RemoveModel variant to OperationInner enum in migrations.rs - Create RemoveModelBuilder for constructing remove operations - Implement make_remove_model_operation in migration_generator.rs - Update relevant utility functions to handle the new operation type - Add tests for the new functionality Fixes #207 * Update cot-cli/src/migration_generator.rs --------- Co-authored-by: Marek Grzelak <[email protected]>
seqre
added a commit
that referenced
this pull request
Mar 4, 2025
This is pointless by itself now, but it will be needed in future changes. refactor: split generating and writing migrations refactor: minor fixes refactor: extract operations to separate struct fix: make tests pass chore: use better method names chore: use new names in tests test: add few chore: add GH sponsors to FUNDING.yml (#222) (cherry picked from commit 098fc5a) fix: include APP_NAME in model (#228) (cherry picked from commit ffc8870) feat: support "Remove Model" in Automatic Migration Generator (#221) * Add support for removing models in automatic migration generator Implement the ability to detect when a model has been removed from the codebase and generate appropriate migration operations. This includes: - Add RemoveModel variant to OperationInner enum in migrations.rs - Create RemoveModelBuilder for constructing remove operations - Implement make_remove_model_operation in migration_generator.rs - Update relevant utility functions to handle the new operation type - Add tests for the new functionality Fixes #207 * Update cot-cli/src/migration_generator.rs --------- Co-authored-by: Marek Grzelak <[email protected]>
seqre
added a commit
that referenced
this pull request
Mar 4, 2025
This is pointless by itself now, but it will be needed in future changes. refactor: split generating and writing migrations refactor: minor fixes refactor: extract operations to separate struct fix: make tests pass chore: use better method names chore: use new names in tests test: add few chore: add GH sponsors to FUNDING.yml (#222) (cherry picked from commit 098fc5a) fix: include APP_NAME in model (#228) (cherry picked from commit ffc8870) feat: support "Remove Model" in Automatic Migration Generator (#221) * Add support for removing models in automatic migration generator Implement the ability to detect when a model has been removed from the codebase and generate appropriate migration operations. This includes: - Add RemoveModel variant to OperationInner enum in migrations.rs - Create RemoveModelBuilder for constructing remove operations - Implement make_remove_model_operation in migration_generator.rs - Update relevant utility functions to handle the new operation type - Add tests for the new functionality Fixes #207 * Update cot-cli/src/migration_generator.rs ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for automatically detecting when models are removed from the codebase and generating the appropriate migration operations. Now when a model exists in the database schema but has been removed from the application code, the migration generator will create a RemoveModel operation to drop the corresponding table.
Changes
RemoveModelvariant toOperationInnerenumRemoveModelBuilderto support the fluent builder patternmake_remove_model_operationfunction inmigration_generator.rsremove_dependencyandget_ops_adding_foreign_keysto handle the new operation typeFixes #207