Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Cargo.lock to project template to avoid broken dependencies #191

Merged
merged 3 commits into from
Feb 23, 2025

Conversation

m4tx
Copy link
Member

@m4tx m4tx commented Feb 23, 2025

By pinning new project's dependencies to specific versions, we avoid problems like #187 which are caused by changes in the dependencies (in this case we were using a prerelease version of a dependency which updated one of its dependencies to edition=2024, but this will also prevent accidental semver-breaking changes from breaking our builds, too).

This also adds a justfile that makes it easy to update the lockfile.

@m4tx m4tx requested a review from seqre February 23, 2025 19:51
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cot-cli/src/main.rs 0.00% 5 Missing ⚠️
Flag Coverage Δ
rust 78.54% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cot-cli/src/new_project.rs 95.12% <ø> (ø)
cot-cli/src/main.rs 0.00% <0.00%> (ø)

By pinning new project's dependencies to specific versions, we avoid
problems like #187 which are caused by changes in the dependencies
(in this case we were using a prerelease version of a dependency which
updated one of its dependencies to edition=2024, but this will also
prevent accidental semver-breaking changes from breaking our builds,
too).

This also adds a justfile that makes it easy to update the lockfile.
@m4tx m4tx force-pushed the project-template-lockfile branch from 39ef88c to 0fcf37b Compare February 23, 2025 20:22
@m4tx m4tx requested a review from seqre February 23, 2025 20:23
@m4tx m4tx enabled auto-merge (squash) February 23, 2025 21:42
@m4tx m4tx merged commit 321b0c4 into master Feb 23, 2025
27 checks passed
@m4tx m4tx deleted the project-template-lockfile branch February 23, 2025 21:52
@cotbot cotbot bot mentioned this pull request Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants