Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: sendTransfer refactor #254

Merged
merged 32 commits into from
Feb 6, 2025
Merged

imp: sendTransfer refactor #254

merged 32 commits into from
Feb 6, 2025

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Feb 4, 2025

Description

closes: #219


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.82%. Comparing base (e0db3bd) to head (319ce10).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   99.48%   99.82%   +0.34%     
==========================================
  Files          13       13              
  Lines         580      568      -12     
==========================================
- Hits          577      567      -10     
+ Misses          3        1       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srdtrk srdtrk marked this pull request as ready for review February 6, 2025 14:47
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of minor comments and questions. Once they are addressed/answered: LGTM!!!

contracts/ICS20Transfer.sol Show resolved Hide resolved
contracts/utils/ICS20Lib.sol Outdated Show resolved Hide resolved
e2e/interchaintestv8/chainconfig/chain_config.go Outdated Show resolved Hide resolved
e2e/interchaintestv8/go.sum Outdated Show resolved Hide resolved
test/solidity-ibc/ICS20TransferTest.t.sol Outdated Show resolved Hide resolved
test/solidity-ibc/ICS20TransferTest.t.sol Outdated Show resolved Hide resolved
@srdtrk srdtrk merged commit ae036e2 into main Feb 6, 2025
61 checks passed
@srdtrk srdtrk deleted the serdar/219-send-refactor branch February 6, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate and refactor ICS20 sendPacket flow
2 participants