Skip to content

Fix compile issue in start.go #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix compile issue in start.go #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions server/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,6 @@ which accepts a path for the resulting pprof file.
}

serverCtx.Logger.Debug("received quit signal")
// TODO: why is this check here? Should not make sense since err is checked above
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this check here? doesnt make sense since the error is checked above. can likely remove it

if err != nil {
serverCtx.Logger.Error(fmt.Sprintf("error on quit: %s", err.Error()))
}

return nil
},
Expand Down
Loading