fix(unorderedtx): issues reported in audit (#21467) #23727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
x/auth/ante/unorderedtx/manager.go
Dismissed
| @@ -145,33 +146,30 @@ | |||
| var txHash TxHash | |||
| copy(txHash[:], buf[:txHashSize]) | |||
|
|
|||
| m.Add(txHash, binary.BigEndian.Uint64(buf[txHashSize:])) | |||
| timeStamp := binary.BigEndian.Uint64(buf[txHashSize:]) | |||
| m.Add(txHash, time.Unix(int64(timeStamp), 0)) | |||
Check failure
Code scanning / gosec
integer overflow conversion uint64 -> uint8 Error
…nto technicallyty/STA-117/backport-auditfix1-e2c6e
…nto technicallyty/STA-117/backport-auditfix1-e2c6e
…nto technicallyty/STA-117/backport-auditfix1-e2c6e
Co-authored-by: Alex | Interchain Labs <[email protected]>
aljo242
reviewed
Feb 25, 2025
x/auth/ante/unordered.go
Outdated
| }, | ||
| } | ||
|
|
||
| const DefaultSha256Cost = 25 |
There was a problem hiding this comment.
i think we should doc this. What is the unit?
There was a problem hiding this comment.
DefaultSha256GasCost and rename all other var uses related to this
x/auth/ante/unordered.go
Outdated
| } | ||
|
|
||
| txHash := sha256.Sum256(ctx.TxBytes()) | ||
| // consume gas in all exec modes to avoid gas estimation discrepancies | ||
| sdkCtx.GasMeter().ConsumeGas(d.sha256Cost, "consume gas for calculating tx hash") |
There was a problem hiding this comment.
One thing I want us to follow up on is "why is the default cost what it is?"
x/auth/ante/unorderedtx/manager.go
Dismissed
| @@ -145,33 +146,30 @@ | |||
| var txHash TxHash | |||
| copy(txHash[:], buf[:txHashSize]) | |||
|
|
|||
| m.Add(txHash, binary.BigEndian.Uint64(buf[txHashSize:])) | |||
| timeStamp := binary.BigEndian.Uint64(buf[txHashSize:]) | |||
| m.Add(txHash, time.Unix(int64(timeStamp), 0)) | |||
…nto technicallyty/STA-117/backport-auditfix1-e2c6e
|
@technicallyty your pull request is missing a changelog! |
aljo242
approved these changes
Feb 26, 2025
technicallyty
merged commit b754f48
into
technicallyty/backport-6ec53aaf54-unorderedtx-part-1
53 of 57 checks passed
technicallyty
deleted the
technicallyty/STA-117/backport-auditfix1-e2c6e
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: STA-117
backports the audit fix from e9eaefa
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...