chore: re-add v1 code #23545
chore: re-add v1 code #23545
Conversation
aljo242
requested review from
a team,
julienrbrt,
tac0turtle,
lucaslopezf,
alpe and
JulianToledano
as code owners
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 62 files out of 161 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:x/slashing
C:x/distribution
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| go func() { | ||
| fmt.Println("Press the Enter Key to terminate all validator processes") | ||
| if _, err := fmt.Scanln(); err == nil { | ||
| close(shutdownCh) // Signal shutdown | ||
| } | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note test
| go func() { | ||
| <-sigCh // Wait for Ctrl+C | ||
| fmt.Println("\nCtrl+C detected, terminating validator processes...") | ||
| close(shutdownCh) // Signal shutdown | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note test
| @@ -12,7 +12,8 @@ MOCKS_DIR = $(CURDIR)/tests/mocks | |||
| HTTPS_GIT := https://github.com/cosmos/cosmos-sdk.git | |||
| DOCKER := $(shell which docker) | |||
| PROJECT_NAME = $(shell git remote get-url origin | xargs basename -s .git) | |||
| COSMOS_BUILD_OPTIONS += ' v2' | |||
|
|
|||
| rocksdb_version=v9.6.1 | |||
There was a problem hiding this comment.
can be deleted rocksdb support has been dropped
There was a problem hiding this comment.
i'd do a git checkout of release/v0.52.x for this file, as it will be mostly be incorrect with git revert
| @@ -24,8 +23,8 @@ test-all: test-unit test-integration test-ledger-mock test-race | |||
| .PHONY: test-system | |||
| test-system: build | |||
| mkdir -p ./tests/systemtests/binaries/ | |||
| cp $(BUILDDIR)/simdv2 ./tests/systemtests/binaries/ | |||
| COSMOS_BUILD_OPTIONS=v2 $(MAKE) -C tests/systemtests test | |||
| cp $(BUILDDIR)/simd ./tests/systemtests/binaries/ | |||
There was a problem hiding this comment.
| cp $(BUILDDIR)/simd ./tests/systemtests/binaries/ | |
| cp $(BUILDDIR)/simd$(if $(findstring v2,$(COSMOS_BUILD_OPTIONS)),v2) ./tests/systemtests/binaries/ |
There was a problem hiding this comment.
should be reverted and brought back
There was a problem hiding this comment.
can be deleted (it is in systemtest/`)
| @@ -116,7 +122,12 @@ func TestGroupCommands(t *testing.T) { | |||
| systest.RequireTxSuccess(t, rsp) | |||
|
|
|||
| // query votes | |||
| voteResp := string(systest.GetRequest(t, fmt.Sprintf("%s/cosmos/group/v1/vote_by_proposal_voter/%s/%s", baseurl, proposalId, valAddr))) | |||
|
|
|||
| // TODO: remove isV2() check once v2 is integrated with grpc gateway | |||
There was a problem hiding this comment.
should be reverted, grpc gateway works in v2
There was a problem hiding this comment.
should be reverted, main should upgrade from 0.52 not 0.50
There was a problem hiding this comment.
should be reverted, confix got loosened check on both branches.
There was a problem hiding this comment.
should be reverted, we should import cosmos/gogoproto not protobuf
There was a problem hiding this comment.
can we reverted, no need to bring back a server dep while it isn't strictly required
There was a problem hiding this comment.
should be reverted, no need to import server here
There was a problem hiding this comment.
should be reverted, that was a linter fix
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...