-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(confix): remove gas-adjustment in v0.52 client toml #20988
Conversation
WalkthroughWalkthroughThe recent changes primarily involve the removal of settings related to gRPC server connections, insecure channel connections, and the gas adjustment factor used in transaction commands from the configuration file Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- tools/confix/data/v0.52-client.toml (1 hunks)
Additional comments not posted (8)
tools/confix/data/v0.52-client.toml (8)
Line range hint
1-3
:
File Header and Comments:The file header and comments are clear and provide useful information about the file format and purpose.
Line range hint
5-7
:
Client Configuration Section:The section header for client configuration is clear and well-formatted.
Line range hint
9-10
:
Chain ID Configuration:The chain ID configuration is correctly specified.
Line range hint
11-12
:
Keyring Backend Configuration:The keyring backend configuration is correctly specified.
Line range hint
13-14
:
Keyring Default Keyname Configuration:The keyring default keyname configuration is correctly specified.
Line range hint
15-16
:
CLI Output Format Configuration:The CLI output format configuration is correctly specified.
17-18
: Node Configuration:The node configuration is correctly specified.
Line range hint
19-20
:
Broadcast Mode Configuration:The broadcast mode configuration is correctly specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- tools/confix/data/v0.52-client.toml (1 hunks)
Additional comments not posted (2)
tools/confix/data/v0.52-client.toml (2)
Line range hint
19-19
:
Impact of removinggrpc-address
.The removal of the
grpc-address
setting means users will need to manually specify the gRPC server endpoint using the--grpc-addr
flag for each command. Ensure this change is well-documented to avoid confusion.
Line range hint
22-22
:
Impact of removinggrpc-insecure
.The removal of the
grpc-insecure
setting means users will need to manually specify the--grpc-insecure
flag for each command if they need to connect over insecure channels. Ensure this change is well-documented to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit