Merge branch 'main' into son/remove_testutil_integration

cosmos · Dec 25, 2024 · e80536f · e80536f
2 parents 92e3cdc + 8ef2f8d
commit e80536f
Show file tree

Hide file tree

Showing 276 changed files with 2,905 additions and 20,237 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -59,7 +59,6 @@
 /x/group/ @kocubinski @akhilkumarpilli @cosmos/sdk-core-dev
 /x/mint/ @lucaslopezf @facundomedica @cosmos/sdk-core-dev
 /x/nft/ @alpe @lucaslopezf @cosmos/sdk-core-dev
-/x/params/ @cosmos/sdk-core-dev # deprecated so whole team
 /x/protocolpool/ @facundomedica @hieuvubk @alpe @cosmos/sdk-core-dev
 /x/simulation/ @cosmos/sdk-core-dev # deprecated so whole team
 /x/slashing/ @testinginprod @raynaudoe @lucaslopezf @cosmos/sdk-core-dev

diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -296,15 +296,6 @@ updates:
     labels:
       - "A:automerge"
       - dependencies
-  - package-ecosystem: gomod
-    directory: "/x/params"
-    schedule:
-      interval: weekly
-      day: wednesday
-      time: "03:05"
-    labels:
-      - "A:automerge"
-      - dependencies
   - package-ecosystem: gomod
     directory: "/x/auth"
     schedule:

diff --git a/.github/pr_labeler.yml b/.github/pr_labeler.yml
@@ -69,8 +69,6 @@
   - x/mint/**/*
 "C:x/nft":
   - x/nft/**/*
-"C:x/params":
-  - x/params/**/*
 "C:x/protocolpool":
   - x/protocolpool/**/*
 "C:x/slashing":

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -18,7 +18,6 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        # go-arch: ["amd64", "arm", "arm64"]
         go-arch: ["amd64", "arm64"] # drop 32 bit support for now (and maybe forever)
     steps:
       - uses: actions/checkout@v4
@@ -48,19 +47,17 @@ jobs:
         ###################
         #### Build App ####
         ###################
-      - name: Build
-        run: GOARCH=${{ matrix.go-arch }} make build
       - name: Build v2
         run: GOARCH=${{ matrix.go-arch }} COSMOS_BUILD_OPTIONS=v2 make build
       - name: Build with rocksdb backend
         if: matrix.go-arch == 'amd64'
-        run: GOARCH=${{ matrix.go-arch }} COSMOS_BUILD_OPTIONS="rocksdb" make build
+        run: GOARCH=${{ matrix.go-arch }} COSMOS_BUILD_OPTIONS=v2,rocksdb make build
       - name: Build with BLS12381
         if: matrix.go-arch == 'amd64'
-        run: GOARCH=${{ matrix.go-arch }} COSMOS_BUILD_OPTIONS="bls12381" make build
+        run: GOARCH=${{ matrix.go-arch }} COSMOS_BUILD_OPTIONS=v2,bls12381 make build
       - name: Build with Secp_cgo
         if: matrix.go-arch == 'amd64'
-        run: GOARCH=${{ matrix.go-arch }} COSMOS_BUILD_OPTIONS="secp" make build
+        run: GOARCH=${{ matrix.go-arch }} COSMOS_BUILD_OPTIONS=v2,secp make build
         ###################
         ## Build Tooling ##
         ###################

diff --git a/.github/workflows/dependabot-update-all.yml b/.github/workflows/dependabot-update-all.yml
@@ -14,7 +14,7 @@ jobs:
     if: ${{ github.actor == 'dependabot[bot]' }}
     steps:
       - name: Generate Token
-        uses: actions/create-github-app-token@5d869da34e18e7287c1daad50e0b8ea0f506ce69 # v1
+        uses: actions/create-github-app-token@c1a285145b9d317df6ced56c09f525b5c2b6f755 # v1
         id: app-token
         with:
           app-id: "${{ secrets.APP_ID }}"

diff --git a/.github/workflows/sims-047.yml b/.github/workflows/sims-047.yml
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -114,46 +114,6 @@ jobs:
           name: "${{ github.sha }}-integration-coverage"
           path: ./tests/integration-profile.out
 
-  test-system: # v2 system tests are in v2-test.yml
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          fetch-tags: true
-      - uses: actions/setup-go@v5
-        with:
-          go-version: "1.23"
-          check-latest: true
-          cache: true
-          cache-dependency-path: |
-            simapp/go.sum
-            systemtest/go.sum
-      - uses: technote-space/[email protected]
-        id: git_diff
-        with:
-          PATTERNS: |
-            **/*.go
-            go.mod
-            go.sum
-            **/go.mod
-            **/go.sum
-            **/Makefile
-            Makefile
-      - name: Install musl lib for simd (docker) binary
-        if: env.GIT_DIFF
-        run: |
-          sudo apt-get install -y musl
-      - name: system tests v1
-        if: env.GIT_DIFF
-        run: |
-          make test-system
-      - uses: actions/upload-artifact@v4
-        if: failure()
-        with:
-          name: "testnet-setup"
-          path: ./systemtests/testnet/
-          retention-days: 3
-
   repo-analysis:
     runs-on: ubuntu-latest
     needs: [tests, test-integration]
@@ -504,29 +464,6 @@ jobs:
         with:
           projectBaseDir: indexer/postgres/
 
-  test-simapp:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-go@v5
-        with:
-          go-version: "1.23"
-          check-latest: true
-          cache: true
-          cache-dependency-path: simapp/go.sum
-      - uses: technote-space/[email protected]
-        id: git_diff
-        with:
-          PATTERNS: |
-            **/*.go
-            simapp/go.mod
-            simapp/go.sum
-      - name: tests simapp
-        if: env.GIT_DIFF
-        run: |
-          cd simapp
-          go test -mod=readonly -timeout 30m -tags='norace ledger test_ledger_mock' ./...
-
   test-simapp-v2:
     runs-on: ubuntu-latest
     steps:
@@ -1199,36 +1136,6 @@ jobs:
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         with:
           projectBaseDir: x/evidence/
-  test-x-params:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-go@v5
-        with:
-          go-version: "1.23"
-          check-latest: true
-          cache: true
-          cache-dependency-path: x/params/go.sum
-      - uses: technote-space/[email protected]
-        id: git_diff
-        with:
-          PATTERNS: |
-            x/params/**/*.go
-            x/params/go.mod
-            x/params/go.sum
-      - name: tests
-        if: env.GIT_DIFF
-        run: |
-          cd x/params
-          go test -mod=readonly -timeout 30m -coverprofile=coverage.out -covermode=atomic -tags='norace ledger test_ledger_mock' ./...
-      - name: sonarcloud
-        if: ${{ env.GIT_DIFF && !github.event.pull_request.draft && env.SONAR_TOKEN != null }}
-        uses: SonarSource/sonarcloud-github-action@master
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-        with:
-          projectBaseDir: x/params/
   test-x-upgrade:
     runs-on: ubuntu-latest
     steps:

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -51,10 +51,13 @@ Every module contains its own CHANGELOG.md. Please refer to the module you are i
 
 ### API Breaking Changes
 
+* (x/params) [#22995](https://github.com/cosmos/cosmos-sdk/pull/22995) Remove `x/params`.  Migrate to the new params system introduced in `v0.47` as demonstrated [here](https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#xparams).
 * (testutil) [#22392](https://github.com/cosmos/cosmos-sdk/pull/22392) Remove `testutil/network` package. Use the integration framework or systemtests framework instead.
 
 ### Deprecated
 
+* (modules) [#22994](https://github.com/cosmos/cosmos-sdk/pull/22994) Deprecate `Invariants` and associated methods.
+
 ## [v0.52.0-rc.1](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.52.0-rc.1) - 2024-12-18
 
 Every module contains its own CHANGELOG.md. Please refer to the module you are interested in.
@@ -2142,7 +2145,7 @@ empty coins slice before it is used to create `banktype.MsgSend`.
 ### State Machine Breaking
 
 * [#10833](https://github.com/cosmos/cosmos-sdk/pull/10833) fix reported tx gas used when block gas limit exceeded.
-* (auth) [#10536](https://github.com/cosmos/cosmos-sdk/pull/10536]) Enable `SetSequence` for `ModuleAccount`.
+* (auth) [#10536](https://github.com/cosmos/cosmos-sdk/pull/10536) Enable `SetSequence` for `ModuleAccount`.
 * (store) [#10218](https://github.com/cosmos/cosmos-sdk/pull/10218) Charge gas even when there are no entries while seeking.
 * (store) [#10247](https://github.com/cosmos/cosmos-sdk/pull/10247) Charge gas for the key length in gas meter.
 * (x/gov) [#10740](https://github.com/cosmos/cosmos-sdk/pull/10740) Increase maximum proposal description size from 5k characters to 10k characters.

diff --git a/README.md b/README.md
@@ -72,7 +72,7 @@ Core dependencies not mentioned here as compatible across all maintained SDK ver
 See an exhaustive list of core dependencies at [cosmossdk.io](https://cosmossdk.io).
 
 | Version                  | v2    | 0.52.z    | 0.50.z         | 0.47.z  |
-| ------------------------ | ----- | --------- | -------------- | ------- |
+|--------------------------|-------|-----------|----------------|---------|
 | cosmossdk.io/core        | 1.y.z | 1.y.z     | 0.11.z         | 0.5.z   |
 | cosmossdk.io/api         | 0.8.z | 0.8.z     | 0.7.z          | 0.3.z   |
 | cosmossdk.io/x/tx        | 1.y.z | 1.y.z     | < 1.y.z        | N/A     |
@@ -89,7 +89,7 @@ Module Dependencies are the modules that an application may depend on and which
 > N/A signals that the module was not available in the Cosmos SDK at that time.
 
 | Cosmos SDK                  | v2    | 0.52.z | 0.50.z |
-| --------------------------- | ----- | ------ | ------ |
+|-----------------------------|-------|--------|--------|
 | cosmossdk.io/x/accounts     | 0.2.z | 0.2.z  | N/A    |
 | cosmossdk.io/x/bank         | 0.2.z | 0.2.z  | X      |
 | cosmossdk.io/x/circuit      | 0.2.z | 0.2.z  | 0.1.z  |
@@ -102,6 +102,7 @@ Module Dependencies are the modules that an application may depend on and which
 | cosmossdk.io/x/group        | 0.2.z | 0.2.z  | X      |
 | cosmossdk.io/x/mint         | 0.2.z | 0.2.z  | X      |
 | cosmossdk.io/x/nft          | 0.2.z | 0.2.z  | 0.1.z  |
+| cosmossdk.io/x/params       | N/A   | 0.2.z  | X      |
 | cosmossdk.io/x/protocolpool | 0.2.z | 0.2.z  | N/A    |
 | cosmossdk.io/x/slashing     | 0.2.z | 0.2.z  | X      |
 | cosmossdk.io/x/staking      | 0.2.z | 0.2.z  | X      |