Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): expose restartThreshold via StarshipContext #577

Merged

Conversation

0xpatrickdev
Copy link
Contributor

  • feat(client): expose restartThreshold via StarshipContext
    • allow api consumers to specify restartThreshold > default value of 3

Context: with the faucet enabled, the agoric pod experiences up to 5 restarts (perhaps the faucet doesn't respect the validator's readiness check?). This change would allow us to use the latest versions of starship in CI.

- allow api consumers to specify restartThreshold > 3
Copy link
Collaborator

@Anmol1696 Anmol1696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anmol1696 Anmol1696 merged commit afaef4e into cosmology-tech:main Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants