Illegal string offset '_elem' in action.php on line 205 / 231 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solution: put the following line at the begin of the foreach loop starting in line 204:
`if ( !isset ( $ref ['_elem'] ) ) { break ; }`
See also https://www.dokuwiki.org/plugin:publish#error_when_using_the_old_revisions_view
solution: put the following line at the begin of the foreach loop starting in line 230 or 231 (inside "handle_recent"):
`if ( !isset ( $ref ['_elem'] ) ) { break ; }`
hh-lohmann
changed the title
sorry, simple PHP break dos not do the full job, we need to check all `$ref` items in the `if` clause that sets `$member` BUT ONLY FOR THIS, not for the whole foreach body See also https://www.dokuwiki.org/plugin:publish#error_when_using_the_old_revisions_view
…RRECTION sorry, simple PHP break does not do the full job, we need to check all `$ref`, and that for the whole foreach body
…le_recent action.php: isset check for $meta['last_change']['date'] @ handle_recent
|
+1 |
1 similar comment
|
+1 |
|
this patch no longer applies to master. could you update it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORRECTED solution: simple PHP break does not do the full job, we need to check all
$refitems (a) for the whole foreach body concerninghandle_recent, and (b) for theifclause that sets$memberbut not for the whole foreach body concerning `handle_revisionsSee also https://www.dokuwiki.org/plugin:publish#error_when_using_the_old_revisions_view