Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around chrome bug #1

Merged
merged 1 commit into from
Apr 21, 2016
Merged

Conversation

thomassuckow
Copy link
Contributor

Chrome rounds down the scrollTop, make it large enough to not result in 0

https://bugs.chromium.org/p/chromium/issues/detail?id=584443

Chrome rounds down the scrollTop, make it large enough to not result in 0
@cosmicexplorer
Copy link
Owner

Sorry, I haven't looked at this or used this in a while and I wrote it when I wasn't that great at js. Can you give an example (some html, perhaps) of what this fixes?

@thomassuckow
Copy link
Contributor Author

http://jsfiddle.net/thomassuckow/gued0nzn/6/

Resizing the preview pane causes the box to change colors

In broken browsers (Chrome 47, Chrome 48, Safari unknown version), it doesn't work when growing vertically because of a rounding bug.

@cosmicexplorer
Copy link
Owner

Oh oops, didn't see that you already posted that in the bug report. Thanks for responding so fast.

However, I'd recommend making a pull request on the repo I pulled the code from. This was just a copy/paste of the repo's code into an NPM package, since at that time that repo didn't have an NPM package of its own. I'll probably delete this in a few days.

@thomassuckow
Copy link
Contributor Author

sdecima/javascript-detect-element-resize#36

Also, yours isn't the same. You export a module, the "official" one modifies the window object.

@cosmicexplorer
Copy link
Owner

Ok, also didn't see that issue for some reason. This looks good.

@cosmicexplorer cosmicexplorer merged commit 599b693 into cosmicexplorer:master Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants