Convert to Solara #16
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the right way to run this for testing? I tried: But this gives me some slightly odd error message (below). Before I try to solve that, is that the right way to try and invoke this? |
|
@jfoster17 I've generally been using |
jfoster17
reviewed
Dec 3, 2024
| powerplant_data.add_component(big*9 + med*4 + small*1, label='Size_binned') | ||
|
|
||
| map = cast(IPyLeafletMapViewer, app.new_data_viewer(IPyLeafletMapViewer, data=tempo_data, state=map_state, show=False)) | ||
| map.map.add(TileLayer(url=stadia_labels_url, pane='labels')) |
There was a problem hiding this comment.
You accidentally removed the definition of the custom "pane" for the label layer. Restoring this here:
map.map.panes = {"labels": {"zIndex": 650}}
Will fix the crash that causes zooming and panning to break.
There was a problem hiding this comment.
This does not solve the problem that the time slider only updates once and then stops working...
There was a problem hiding this comment.
That fixed the zooming/panning for me as well.
jfoster17
reviewed
Dec 12, 2024
src/tempods/pages/__init__.py
Outdated
| def update_image(index): | ||
| print(f"update_image: {index}") | ||
| set_time_index(index) | ||
| timestep = time_values[index] |
There was a problem hiding this comment.
This needs to be:
timestep = time_values[index].item()
to cast the solara-returned np.int64 down to an int (otherwise ipyleaflet casts the np.int64 to a string, which breaks things)
jfoster17
reviewed
Dec 12, 2024
src/tempods/pages/__init__.py
Outdated
| # Our remote dataset does not have real components representing latitude and longitude. We link to the only components | ||
| # it does have so that we can display this on the same viewer without trigger and IncompatibleAttribute error | ||
| app.add_link(app.data_collection["Power_Plants"], 'Longitude', app.data_collection["TEMPO"], 'Pixel Axis 0') | ||
| app.add_link(app.data_collection["Power_Plants"], 'Latitude', app.data_collection["TEMPO"], 'TEMPO_NO2_L3_V03_HOURLY_TROPOSPHERIC_VERTICAL_COLUMN_BETA') |
There was a problem hiding this comment.
Also the variable name on the server changed, so this needs to be:
TEMPO_NO2_L3_V03_HOURLY_TROPOSPHERIC_VERTICAL_COLUMN
(i.e. just remove the _BETA)
There was a problem hiding this comment.
You'll also need the latest glue_map because I hacked the component name there instead of doing it properly. I've now hacked it to the current correct version and next time I'll certainly fix it properly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the story into Solara, using #9 as a starting point but putting the content in the main app page. This also converts the subset control widget to a Solara component.
I'm running into issues just like we saw on #9 - in particular, the interaction between the controls and the image layer on the map viewer seems problematic. I've also noticed that the image layer doesn't update when the map zooms, and I get some errors in the console. Still working on investigating these.