Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an alert for changes to the story #85

Closed
wants to merge 2 commits into from

Conversation

johnarban
Copy link
Contributor

This adds a simple alert to inform users about changes to the story. In it's current presentation it is added/removed manually. But we could add a built in time limit (like only show for 7 days).

This will be useful to have once we the larger changes to how we display current events, or if we add features (like anciliary data layers, or links out to that days data on earthdata, etc)

this component will focus the content once it is displayed and then return focus to the button when closed
@patudom
Copy link
Contributor

patudom commented Dec 9, 2024

A few thoughts on this:

  • Can you please put the snackbar in the upper right of the screen, near the button? Contextually, it feels like it wants to be associated with the button.
  • I think we want to separate general user interface updates (like the new lat/long URL in Save map and time state in URL #89) from detailed science updates that maynot be meaningful to the general user (like the update to how the data are processed).
  • I think we do need to have a popup somewhere that describes how the data are processed, and changes like that can go in some history there.
  • Should the popup box link to a longer historical "change log"?
  • Should the SnackbarAlert be a component in the vue-toolkit repo instead of here?
  • On my phone, the button overlaps the title. It probably should go below the title?
    IMG_5153

@johnarban
Copy link
Contributor Author

Closing this as it's changes have been merged into #89

@johnarban johnarban closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants