Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure we always try to get the newest manifest available #58

Merged
merged 1 commit into from
Jun 11, 2024
Merged

make sure we always try to get the newest manifest available #58

merged 1 commit into from
Jun 11, 2024

Conversation

johnarban
Copy link
Contributor

Due to browser caching, refreshing the page after updating the data on tempo-data-holdings does not immediately result in receiving the new data manifest. The uses "cache busting" to grab the new manifest file.

@johnarban johnarban requested a review from Carifio24 June 11, 2024 14:31
Carifio24
Carifio24 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@Carifio24 Carifio24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is a file that I imagine will be frequently changing (and that we don't want to host a million versions of), I think the query parameter is a good way to go for cache busting.

@patudom patudom merged commit 549de94 into cosmicds:main Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carifio24 Carifio24 Carifio24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnarban @Carifio24 @patudom