-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save map and time state in URL #89
base: main
Are you sure you want to change the base?
Conversation
this component will focus the content once it is displayed and then return focus to the button when closed
This is looking good, @johnarban! One thing I'm noticing is that the zoom level doesn't seem to get taken back in when I use the copied url. This: Gets turned into this: Another question I have is whether, instead of having the url explicitly change continuously as I pan around, whether it would be less distracting to the user to make a "share" button like we have on the eclipse stories? (and is there any sort of extra cost, either in terms of computational performance or any sort of mapbox credits for continuously displaying the info in the url)? |
Fixed the zoom issue (I searched for @patudom - There is no (or incredibly little) additional overhead in updating the url, and it's an easy way to copy the url. We could have a button as well, but I know for me, I often copy urls from the toolbar. It only updates after a change, not while dragging or zooming, and doesn't require any mapbox calls. |
This PR fixes #88 by creating a sharable url