-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stage 4 waiting room #554
Open
Carifio24
wants to merge
14
commits into
cosmicds:main
Choose a base branch
from
Carifio24:sitting-in-the-waiting-room
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carifio24
force-pushed
the
sitting-in-the-waiting-room
branch
from
October 28, 2024 20:03
9bb2a74
to
fb3d654
Compare
Carifio24
force-pushed
the
sitting-in-the-waiting-room
branch
from
November 19, 2024 06:31
60c716e
to
76a70b1
Compare
Marking as a draft again while I make some updates to handle some items from #660. |
…nt of students who have completed their measurements.
…even after advancing is allowed.
…ssary) if not on waiting room.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of the stage 4 waiting room. The behavior here differs slightly from the Voila version in that we now activate the advance button when enough students have completed their data, rather than the abrupt transition in the Voila version.
At the moment this si a bit difficult to test. I was able to test the class data polling functionality by continually using a dynamic checking condition:
Also, if you then want to reset the
enough_students_ready
in your student's story state, you can run