Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the big yaml cleanup #479

Merged
merged 2 commits into from
Dec 1, 2024
Merged

the big yaml cleanup #479

merged 2 commits into from
Dec 1, 2024

Conversation

MilonPL
Copy link
Contributor

@MilonPL MilonPL commented Nov 21, 2024

About the PR

cleans up all of the CD yaml files:

  • adds trailing spaces to comments
  • removes random whitespaces
  • removes random newlines
  • adds a newline at EOF for all files
  • changes the prototype order to match yaml conventions:
    • type
    • abstract
    • parent
    • id
    • name
    • suffix
    • description
    • categories
    • components
  • switches to entitytables for lockers or other large fills

Why / Balance

i got bored

<aquif: Add progress report message>
Changelog

There was a fairly large cleanup of YAML files. Please report any regressions. The most notable changes happened to Cosmatic Drift's species (Avali, Vulpkin, and Rodentia).

Copy link
Collaborator

@dffdff2423 dffdff2423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed the code and it seems fine. If anything breaks we should just revert the entire PR.

@MilonPL
Copy link
Contributor Author

MilonPL commented Nov 24, 2024

tests pass so it must be fine, surely

@LankLTE LankLTE merged commit 40fd00f into cosmatic-drift-14:master Dec 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants