Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lost and found ui #475

Merged
merged 4 commits into from
Nov 20, 2024
Merged

lost and found ui #475

merged 4 commits into from
Nov 20, 2024

Conversation

MilonPL
Copy link
Contributor

@MilonPL MilonPL commented Nov 19, 2024

About the PR

title
fixes, cleanup, major bullshittery
strips the character of their items, stores it in a container, updates the list in the LostAndFoundComponent to render the UI, works like upstream's cryo more or less
the locker isn't a locker anymore since it just opens the ui

Why / Balance

Closes #443
Closes #444
Closes #457

Media

Click me!

image

image

Copy link
Collaborator

@dffdff2423 dffdff2423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see any major issues with the code. The only possible issue I see is that upstream station records are not being deleted, but that should not be a large deal.

Could you restrict the locker to only the captain and HoP like it was before?

@MilonPL
Copy link
Contributor Author

MilonPL commented Nov 19, 2024

Could you restrict the locker to only the captain and HoP like it was before?

do you want me to lock the entire UI behind access using ActivableUIRequiresAccess or just limit who can retrieve items but make viewing available to everyone?

The only possible issue I see is that upstream station records are not being deleted

not intentional i overlooked it

@dffdff2423
Copy link
Collaborator

do you want me to lock the entire UI behind access using ActivableUIRequiresAccess or just limit who can retrieve items but make viewing available to everyone?

I don't really have a preference. Ether works.

@LankLTE
Copy link
Contributor

LankLTE commented Nov 20, 2024

Description (and maybe sprite eventually but less so) will probably need to be changed once other methods than cryosleeping exist but for now it doesn't matter.

@LankLTE LankLTE merged commit f491408 into cosmatic-drift-14:master Nov 20, 2024
9 checks passed
@MilonPL MilonPL deleted the cryo-ops branch November 20, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants