Feature 2fa #213
Merged
Feature 2fa #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
PhamAnhHoang
force-pushed
the
feature/2FA
branch
from
bb58b97
to
ee468b8
Compare
Closed
vygandas
reviewed
Feb 7, 2024
| }) | ||
|
|
||
| interface Options { | ||
| onSuccess?: (response: any) => void |
There was a problem hiding this comment.
Maybe it's a good place for DTO?
vygandas
requested changes
Feb 10, 2024
There was a problem hiding this comment.
Also, missing recovery codes which should have been displayed when 2fa was confirmed.
When trying to login, get error:
[Nest] 74169 - 02/10/2024, 4:08:17 PM ERROR [ExceptionsHandler] The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received null
TypeError: The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received null
at new NodeError (node:internal/errors:405:5)
at Function.from (node:buffer:333:9)
at new Buffer (node:buffer:288:17)
at Object.exports.decode (/Users/vygandas/git/isomera/node_modules/thirty-two/lib/thirty-two/thirty-two.js:87:16)
at Object.keyDecoder (/Users/vygandas/git/isomera/node_modules/@otplib/plugin-thirty-two/index.js:17:20)
at authenticatorDecoder (/Users/vygandas/git/isomera/node_modules/@otplib/core/index.js:413:18)
at authenticatorCheckWithWindow (/Users/vygandas/git/isomera/node_modules/@otplib/core/index.js:423:37)
at Authenticator.checkDelta (/Users/vygandas/git/isomera/node_modules/@otplib/core/index.js:436:12)
at Authenticator.check (/Users/vygandas/git/isomera/node_modules/@otplib/core/index.js:358:24)
at Authenticator.verify (/Users/vygandas/git/isomera/node_modules/@otplib/core/index.js:365:17)
Missing .env maybe or just a bug?
| @@ -102,9 +105,15 @@ export class AuthController { | |||
| @Post('/refresh') | |||
| @HttpCode(HttpStatus.OK) | |||
| async refreshToken( | |||
| @AuthUser() user: Pure<UserEntity> | |||
| @AuthUser() user: Pure<UserEntity> & { isTwoFactorAuthenticated: boolean } | |||
There was a problem hiding this comment.
Shouldn't this prop already be in UserEntity?
There was a problem hiding this comment.
This field doesn't exist in the entity because it's not being stored in the db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Describe the technical changes you did.
Why is it needed?
Describe the issue you are solving.
How to test it?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request