small fixes

cortip · Dec 16, 2023 · 9629d11 · 9629d11
1 parent 039d5f2
commit 9629d11
Show file tree

Hide file tree

Showing 17 changed files with 843 additions and 935 deletions.
diff --git a/.github/workflows/pr_all_affected_test.yml b/.github/workflows/pr_all_affected_test.yml
@@ -32,12 +32,6 @@ jobs:
       - name: 'Install dependencies'
         run: yarn install
 
-      - name: 'Link dependencies for mobile app'
-        run: |
-          npx nx run mobile:install
-          npx nx run mobile:sync-deps
-          npx nx run mobile:ensure-symlink
-
       - name: Run Affected Unit Tests
         shell: bash
         run:

diff --git a/.github/workflows/pretty_linted_code.yml b/.github/workflows/pretty_linted_code.yml
@@ -26,12 +26,6 @@ jobs:
       - name: 'Install dependencies'
         run: yarn install
 
-      - name: 'Link dependencies for mobile app'
-        run: |
-          npx nx run mobile:install
-          npx nx run mobile:sync-deps
-          npx nx run mobile:ensure-symlink
-
       - name: "Check it's pretty"
         run: yarn prettier:check
 

diff --git a/README.md b/README.md
@@ -192,11 +192,11 @@ Consistency is important.
 This is pretty simple, just
 
 ```
-make nx run-many -- -t test
+nx run-many -- -t test
 ```
 
 ```
-make nx run-many -- -t e2e
+nx run-many -- -t e2e
 ```
 
 ### Running services
@@ -206,19 +206,19 @@ make nx run-many -- -t e2e
 This will launch API service on port 8080:
 
 ```
-make nx serve-api
+nx run api:serve
 ```
 
 This will launch platform on port 4200:
 
 ```
-make nx serve-platform
+nx run platform:serve
 ```
 
 This will launch landing on port 3030:
 
 ```
-make nx serve-landing
+nx landing:serve
 ```
 
 ## REPL for Nest.js

diff --git a/apps/api-e2e/project.json b/apps/api-e2e/project.json
@@ -1,22 +1,30 @@
 {
   "name": "api-e2e",
   "$schema": "../../node_modules/nx/schemas/project-schema.json",
-  "implicitDependencies": ["api"],
+  "implicitDependencies": [
+    "api"
+  ],
   "projectType": "application",
   "targets": {
     "e2e": {
       "executor": "@nx/jest:jest",
-      "outputs": ["{workspaceRoot}/coverage/{e2eProjectRoot}"],
+      "outputs": [
+        "{workspaceRoot}/coverage/{e2eProjectRoot}"
+      ],
       "options": {
         "jestConfig": "apps/api-e2e/jest.config.ts",
         "passWithNoTests": true
       }
     },
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
+      "outputs": [
+        "{options.outputFile}"
+      ],
       "options": {
-        "lintFilePatterns": ["apps/api-e2e/**/*.{js,ts}"]
+        "lintFilePatterns": [
+          "apps/api-e2e/**/*.{js,ts}"
+        ]
       }
     }
   }

diff --git a/apps/api/project.json b/apps/api/project.json
@@ -7,28 +7,40 @@
     "build": {
       "executor": "nx:run-commands",
       "options": {
-        "commands": ["nest build -c apps/api/nest-cli.json"]
+        "commands": [
+          "nest build -c apps/api/nest-cli.json"
+        ]
       },
-      "outputs": ["{options.outputPath}"]
+      "outputs": [
+        "{options.outputPath}"
+      ]
     },
     "serve": {
       "executor": "nx:run-commands",
       "options": {
-        "commands": ["nest start --watch -c apps/api/nest-cli.json"]
+        "commands": [
+          "nest start --watch -c apps/api/nest-cli.json"
+        ]
       },
-      "outputs": ["{options.outputPath}"]
+      "outputs": [
+        "{options.outputPath}"
+      ]
     },
     "build:webpack": {
       "executor": "@nx/webpack:webpack",
-      "outputs": ["{options.outputPath}"],
+      "outputs": [
+        "{options.outputPath}"
+      ],
       "defaultConfiguration": "production",
       "options": {
         "target": "node",
         "compiler": "tsc",
         "outputPath": "dist/apps/api",
         "main": "apps/api/src/main.ts",
         "tsConfig": "apps/api/tsconfig.app.json",
-        "assets": ["apps/api/src/assets"],
+        "assets": [
+          "apps/api/src/assets"
+        ],
         "isolatedConfig": true,
         "webpackConfig": "apps/api/webpack.config.js"
       },
@@ -54,14 +66,20 @@
     },
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
+      "outputs": [
+        "{options.outputFile}"
+      ],
       "options": {
-        "lintFilePatterns": ["apps/api/**/*.ts"]
+        "lintFilePatterns": [
+          "apps/api/**/*.ts"
+        ]
       }
     },
     "test": {
       "executor": "@nx/jest:jest",
-      "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
+      "outputs": [
+        "{workspaceRoot}/coverage/{projectRoot}"
+      ],
       "options": {
         "jestConfig": "apps/api/jest.config.ts",
         "passWithNoTests": true

diff --git a/apps/landing-e2e/project.json b/apps/landing-e2e/project.json
@@ -19,12 +19,18 @@
     },
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
+      "outputs": [
+        "{options.outputFile}"
+      ],
       "options": {
-        "lintFilePatterns": ["apps/landing-e2e/**/*.{js,ts}"]
+        "lintFilePatterns": [
+          "apps/landing-e2e/**/*.{js,ts}"
+        ]
       }
     }
   },
   "tags": [],
-  "implicitDependencies": ["landing"]
+  "implicitDependencies": [
+    "landing"
+  ]
 }
diff --git a/apps/landing/project.json b/apps/landing/project.json
@@ -6,7 +6,9 @@
   "targets": {
     "build": {
       "executor": "@nx/next:build",
-      "outputs": ["{options.outputPath}"],
+      "outputs": [
+        "{options.outputPath}"
+      ],
       "defaultConfiguration": "production",
       "options": {
         "outputPath": "dist/apps/landing"
@@ -44,7 +46,9 @@
     },
     "test": {
       "executor": "@nx/jest:jest",
-      "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
+      "outputs": [
+        "{workspaceRoot}/coverage/{projectRoot}"
+      ],
       "options": {
         "jestConfig": "apps/landing/jest.config.ts",
         "passWithNoTests": true
@@ -58,9 +62,13 @@
     },
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
+      "outputs": [
+        "{options.outputFile}"
+      ],
       "options": {
-        "lintFilePatterns": ["apps/landing/**/*.{ts,tsx,js,jsx}"]
+        "lintFilePatterns": [
+          "apps/landing/**/*.{ts,tsx,js,jsx}"
+        ]
       }
     }
   },

diff --git a/apps/mobile-e2e/project.json b/apps/mobile-e2e/project.json
@@ -68,12 +68,18 @@
     },
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
+      "outputs": [
+        "{options.outputFile}"
+      ],
       "options": {
-        "lintFilePatterns": ["apps/mobile/**/*.{ts,tsx,js,jsx}"]
+        "lintFilePatterns": [
+          "apps/mobile/**/*.{ts,tsx,js,jsx}"
+        ]
       }
     }
   },
   "tags": [],
-  "implicitDependencies": ["mobile"]
+  "implicitDependencies": [
+    "mobile"
+  ]
 }
diff --git a/apps/mobile/project.json b/apps/mobile/project.json
@@ -6,7 +6,10 @@
   "targets": {
     "start": {
       "executor": "@nx/expo:start",
-      "dependsOn": ["ensure-symlink", "sync-deps"],
+      "dependsOn": [
+        "ensure-symlink",
+        "sync-deps"
+      ],
       "options": {
         "port": 8081
       }
@@ -19,14 +22,20 @@
     },
     "run-ios": {
       "executor": "@nx/expo:run",
-      "dependsOn": ["ensure-symlink", "sync-deps"],
+      "dependsOn": [
+        "ensure-symlink",
+        "sync-deps"
+      ],
       "options": {
         "platform": "ios"
       }
     },
     "run-android": {
       "executor": "@nx/expo:run",
-      "dependsOn": ["ensure-symlink", "sync-deps"],
+      "dependsOn": [
+        "ensure-symlink",
+        "sync-deps"
+      ],
       "options": {
         "platform": "android"
       }
@@ -53,7 +62,10 @@
     },
     "prebuild": {
       "executor": "@nx/expo:prebuild",
-      "dependsOn": ["ensure-symlink", "sync-deps"],
+      "dependsOn": [
+        "ensure-symlink",
+        "sync-deps"
+      ],
       "options": {}
     },
     "install": {
@@ -66,7 +78,10 @@
     },
     "export": {
       "executor": "@nx/expo:export",
-      "dependsOn": ["ensure-symlink", "sync-deps"],
+      "dependsOn": [
+        "ensure-symlink",
+        "sync-deps"
+      ],
       "options": {
         "platform": "all",
         "outputDir": "../../dist/apps/mobile"
@@ -80,14 +95,20 @@
     },
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
+      "outputs": [
+        "{options.outputFile}"
+      ],
       "options": {
-        "lintFilePatterns": ["apps/mobile/**/*.{ts,tsx,js,jsx}"]
+        "lintFilePatterns": [
+          "apps/mobile/**/*.{ts,tsx,js,jsx}"
+        ]
       }
     },
     "test": {
       "executor": "@nx/jest:jest",
-      "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
+      "outputs": [
+        "{workspaceRoot}/coverage/{projectRoot}"
+      ],
       "options": {
         "jestConfig": "apps/mobile/jest.config.ts"
       }

diff --git a/apps/platform-e2e/project.json b/apps/platform-e2e/project.json
@@ -22,12 +22,18 @@
     },
     "lint": {
       "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
+      "outputs": [
+        "{options.outputFile}"
+      ],
       "options": {
-        "lintFilePatterns": ["apps/platform-e2e/**/*.{js,ts}"]
+        "lintFilePatterns": [
+          "apps/platform-e2e/**/*.{js,ts}"
+        ]
       }
     }
   },
   "tags": [],
-  "implicitDependencies": ["platform"]
+  "implicitDependencies": [
+    "platform"
+  ]
 }