Add active series limit for nativeHistograms samples #6796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paurush Garg <[email protected]>
Signed-off-by: Paurush Garg <[email protected]>
Signed-off-by: Paurush Garg <[email protected]>
harry671003
reviewed
Jun 6, 2025
Signed-off-by: Paurush Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In addition to the current activeSeries limit on float+histogram samples, this PR adds an active series limit for specifically for nativeHistograms samples.
This is done, b/c the ingestion of native histograms samples is much more CPU intensive than that of float samples - adding nativeHistogram samples specific ingestions limit to protect the service and to allow clients to adjust the NH series ingestion.
Currently, Prometheus doesn't provide a way to count the specific active nativeHistogram series in the head and hence this PR uses the activeNativeHistograms series count from Cortex - which differs in the way activeSeries is counted.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]