ci: Upgrade golangci-linter to v2 #6739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
changed the title
friedrichg
reviewed
May 13, 2025
SungJin1212
force-pushed
the
upgrade-golangci-linter-v2
branch
from
9892da8 to
0b49e9d
Compare
yeya24
approved these changes
May 21, 2025
SungJin1212
force-pushed
the
upgrade-golangci-linter-v2
branch
from
35f5192 to
aaf5592
Compare
friedrichg
reviewed
Jun 12, 2025
pkg/util/validation/limits.go
Outdated
| @@ -23,7 +23,7 @@ import ( | |||
| util_log "github.com/cortexproject/cortex/pkg/util/log" | |||
| ) | |||
|
|
|||
| var errMaxGlobalSeriesPerUserValidation = errors.New("The ingester.max-global-series-per-user limit is unsupported if distributor.shard-by-all-labels is disabled") | |||
| var errMaxGlobalSeriesPerUserValidation = errors.New("the ingested.max-global-series-per-user limit is unsupported if distributor.shard-by-all-labels is disabled") | |||
There was a problem hiding this comment.
Suggested change
| var errMaxGlobalSeriesPerUserValidation = errors.New("the ingested.max-global-series-per-user limit is unsupported if distributor.shard-by-all-labels is disabled") | |
| var errMaxGlobalSeriesPerUserValidation = errors.New("the ingester.max-global-series-per-user limit is unsupported if distributor.shard-by-all-labels is disabled") |
pkg/ring/kv/consul/client.go
Outdated
Comment on lines
33
to
34
| // ErrNotFound is returned by ConsulClient.Get. | ||
| ErrNotFound = fmt.Errorf("Not found") | ||
| ErrNotFound = fmt.Errorf("not found") |
There was a problem hiding this comment.
I think this is never used, but I am not sure.
There was a problem hiding this comment.
I think it is safe to delete since it is never used.
SungJin1212
force-pushed
the
upgrade-golangci-linter-v2
branch
from
aaf5592 to
3dc0291
Compare
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
upgrade-golangci-linter-v2
branch
from
3dc0291 to
bcb1843
Compare
friedrichg
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
golangci-linterversion to v2 (v2.1.6). It migrates the.golangci.ymlto v2 and resolves some lint issues according to v2.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]