-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement/audience can accept list of string #7
Open
Marco-Parente
wants to merge
3
commits into
corsac-dart:master
Choose a base branch
from
paikka:improvement/audience-can-accept-list-of-string
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
4f5a910
Audience now accepts either a single string or a list of strings
Marco-Parente 180b665
Merge pull request #1 from paikka/fix-audience-can-accept-list-of-string
Marco-Parente 592c600
Audience now accepts either a single string or a list of strings
Marco-Parente File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -133,7 +133,7 @@ class JWT { | |
String get issuer => _claims['iss']; | ||
|
||
/// The audience of this token (value of standard `aud` claim). | ||
String get audience => _claims['aud']; | ||
List<String> get audience => _claims['aud'].cast<String>(); | ||
|
||
/// The time this token was issued (value of standard `iat` claim). | ||
int get issuedAt => _claims['iat']; | ||
|
@@ -185,8 +185,12 @@ class JWTBuilder { | |
} | ||
|
||
/// Token audience (standard `aud` claim). | ||
void set audience(String audience) { | ||
_claims['aud'] = audience; | ||
void set audience(dynamic audience) { | ||
if (audience is String) { | ||
_claims['aud'] = [audience]; | ||
} else if (audience is List<String>) { | ||
_claims['aud'] = audience; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly here, if someone wants to set |
||
} | ||
|
||
/// Token issued at timestamp in seconds (standard `iat` claim). | ||
|
@@ -333,7 +337,7 @@ class JWTValidator { | |
errors.add('The token issuer is invalid.'); | ||
} | ||
|
||
if (audience is String && audience != token.audience) { | ||
if (audience is String && !token.audience.contains(audience)) { | ||
errors.add('The token audience is invalid.'); | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to spec audience can either be a list or a single string value.
It seems that we should preserve this, which means having
audience
type asObject
+ updating dartdoc for the property to describe possible return values.WDYT?