more tidy and mull

.clang-tidy

@@ -32,6 +32,7 @@ Checks: '*,
   -boost-use-ranges,
   -cppcoreguidelines-avoid-magic-numbers,
   -cppcoreguidelines-macro-usage,
+  -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
   -fuchsia-overloaded-operator,
   -fuchsia-trailing-return,
   -llvmlibc-*,
@@ -43,6 +44,7 @@ Checks: '*,
 #  -boost-use-ranges                                      // would introduce a dependency on Boost
 #  -clang-diagnostic-deprecated-declarations              // some test run deprecated functions on purpose
 #  -cppcoreguidelines-avoid-magic-numbers,                // all tests use magic numbers
+#  -cppcoreguidelines-pro-bounds-array-to-pointer-decay   // for Boost Lightweight test BOOST_TEST
 #  -cppcoreguidelines-macro-usage,                        // BLAS adaptors uses a lot of macros
 #  -fuchsia-overloaded-operator,                          // this library overloads operators (==, <, +, &)
 #  -llvmlibc-*,                                           // nonsense warnings, for llvm developers

include/boost/multi/detail/layout.hpp

@@ -847,7 +847,8 @@ struct layout_t
 
 	constexpr auto scale(size_type num, size_type den) const {
 		assert( (stride_*num) % den == 0 );
-		return layout_t{sub_.scale(num, den), stride_*num/den, offset_*num/den, nelems_*num/den};
+		assert(offset_ == 0);  // TODO(correaa) implement ----------------vvv
+		return layout_t{sub_.scale(num, den), stride_*num/den, offset_ /* *num/den */, nelems_*num/den};
 	}
 };
 

test/element_access.cpp

@@ -141,7 +141,7 @@ auto main() -> int {  // NOLINT(readability-function-cognitive-complexity,bugpro
 		{
 			auto beg1 = arr({1, 3}, {2, 5}).elements().begin();
 			auto end1 = arr({1, 3}, {2, 5}).elements().end();
-			for(;end1 != beg1; --end1) {}  // NOLINT(altera-id-dependent-backward-branch)
+			for(;end1 != beg1; --end1) {}  // NOLINT(altera-id-dependent-backward-branch,altera-unroll-loops)
 			BOOST_TEST( end1 == beg1 );
 		}
 	}