Implement Conops MVP #176
Open
Implement Conops MVP #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlyNat75
requested review from
ZachGarcia42,
cameron-goddard,
nragland,
maxslarsson and
bwz5
as code owners
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (12/08/24)1 reviewer was added to this PR based on Zach Garcia's automation. |
ZachGarcia42
requested changes
Dec 9, 2024
There was a problem hiding this comment.
So fairly major bug here: The Websocket connection for receiving and requesting telemetry is only open on the telemetry page, and closes when going to the Controls or Conops pages. You'll need to probably just open a new websocket on the Conops pages to receive and display telemetry
ZachGarcia42
requested changes
Dec 9, 2024
| title="Igniter" | ||
| buttons={[ | ||
| { | ||
| label: "Arm", |
There was a problem hiding this comment.
Change to Ignite and Ignited I think
| variant="default" | ||
| className="fixed bottom-6 right-6 px-6 py-6 text-lg rounded-lg shadow-lg" | ||
| > | ||
| {"Next Page"} |
There was a problem hiding this comment.
Add previous page buttons
| @@ -0,0 +1,66 @@ | |||
| import { auth } from "@/app/auth"; | |||
There was a problem hiding this comment.
add next page that forwards to telemetry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly probably will need a few edits/ additions before officially MVP. To be discussed during code review