-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend][LLVM] Runtime support for any bitwidth integer numpy input #493
Open
zzzDavid
wants to merge
15
commits into
cornell-zhang:main
Choose a base branch
from
zzzDavid:anywidth-args
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… extension easier
chhzh123
approved these changes
Mar 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do you have other things to add?
|
This was referenced Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Up until this PR, the top function input/output argument type has been set to 64-bit integer type (for integer type args), and type casting is done inside the function body. This was due to the fact that numpy has only 8, 16, 32, 64-bit integer types.
This PR extends
hcl.Array
and LLVM runtime to support arbitrary bitwidth input arguments from numpy array.Methods
Byte-as-field numpy array
To store arbitrary width integer data as numpy arrays, we use struct-type numpy arrays, with each byte as a field. Therefore, each integer scalar is represented as a struct of bytes, and the bytes are contiguous in the memory.
Arbitrary data representation
When input data is wider than 64-bit, it cannot be represented as a numpy scalar type. Instead, we use multidimensional lists of integers in Python to represent input tensors, because Python integers can have arbitrary bitwidth.
MLIR arbitrary bitwidth integer alignment
When passing data from numpy to an MLIR's ExecutionEngine as input arguments, we are creating C Struct from numpy ndarrays with the
ctypes
module in Python. Through a series of experiments, I found that the required alignment of such C Struct is not byte-level, instead, it depends on the integer bitwidth:Changes
make_anybitwidth_numpy_array
is moved fromir_builder.py
toutils.py
hcl.Array.np_array
is refactored and extended to support any bitwidth dataLimitations
fixed-to-integer
pass needs to be updated in the IR first. Support for fixed-point type will be added by another PR.