Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glitchy Login Fix #248

Merged
merged 9 commits into from
Feb 21, 2025
Merged

Glitchy Login Fix #248

merged 9 commits into from
Feb 21, 2025

Conversation

shah-esha
Copy link
Collaborator

@shah-esha shah-esha commented Feb 21, 2025

Summary

This PR is a fix for a high priority bug

  • Enabled reconnection to ensure the app can recover gracefully from disconnects whenever possible

Remaining TODOs:

  • Testing

Test Plan

Test using TestFlight:

Swipe out of the app so it's in the background. Wait a few minutes and enter the app again. The bug is fixed if the app doesn't divert back to the login page.

Notes

We want to keep an eye out to make sure these changes don't break other parts of the app.

@dti-github-bot
Copy link
Member

dti-github-bot commented Feb 21, 2025

[diff-counting] Significant lines: 29.

@3TTemi 3TTemi requested review from 3TTemi and removed request for 3TTemi February 21, 2025 03:18
Copy link
Contributor

@3TTemi 3TTemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to go as we reviewed during dev sesh and ready for testing

@3TTemi 3TTemi merged commit 82a7f87 into master Feb 21, 2025
9 of 12 checks passed
@3TTemi 3TTemi deleted the es999/login-bug-fix branch February 21, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants