Document AuthFlow and Glitchy Login Fix #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 141. |
ambers7
reviewed
Feb 15, 2025
3TTemi
changed the title
shah-esha
reviewed
Feb 16, 2025
shah-esha
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR to fix high priroity bug:
Remaining TODOs:
Test Plan
Do the following test on test flight:
Specifically by going into a challenge and then swiping out to another app, waiting for a few minutes for a disconnect, and then returning back to the CornellGo app.
Notes
During testing, I found there there may be another navigation bug related to overlaying pages which occurs after the user signs out and logs back into the app. It is visible through a back button on the search filter home page that should not be there. Further attention needs to be looked into this.