-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Achievement page #207
Merged
Merged
Achievement page #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filters mostly working now (except Category)
removed commented code
Implemented Filtering changes (except for categories)
Co-authored-by: neketka <[email protected]>
[diff-counting] Significant lines: 569. |
neketka
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
shah-esha
pushed a commit
that referenced
this pull request
Dec 4, 2024
* beginning structure, wip * Filters mostly working now (except Category) Filters mostly working now (except Category) * removed commented code removed commented code * Implemented Filtering changes (except for categories) Implemented Filtering changes (except for categories) * removed api keys from server env * Enrollment type enum * fixed filtering bugs after merging * added friendly names, fixed category filtering * Achievements Page UI work * fixed miles away value in preview * fix bug where listview breaks * fix formatting * Achievements UI no backend * Achievement model blocked by achievementTracker\ * UI adjustments * Achievements UI completed, Hint icon fixed * fixed issues caused by conflict, edited cells on profile page * removed some old print statements --------- Co-authored-by: nit0107 <[email protected]> Co-authored-by: Nitya <[email protected]> Co-authored-by: cathli66 <[email protected]> Co-authored-by: neketka <[email protected]> Co-authored-by: cathli66 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is the first step towards implementing achievements page