Nmp79/implementing filtering #184
Conversation
Filters mostly working now (except Category)
removed commented code
Implemented Filtering changes (except for categories)
There was a problem hiding this comment.
Just suggestions. The filter defaults too easy difficulty (not sure if we should clear all filters when the app opens). The difficulty section also is not togglable like the other categories. Location names look like how they are in the DB which we should parse into actually names. Otherwise, good work, ui looks good!
|
[diff-counting] Significant lines: 455. |
partial checkin for search/filter change
partial checkin...search bar implementation
now the old filtering works
Searching by challenge name and location now work from search bar
Fixed issue with filters not filtering correctly
Now journeys also do filtering
There was a problem hiding this comment.
Everything overall looks great and works as expected! I went ahead and fixed some minor errors with the height of the home nav bar and search bar. You hard coded it the height in pixels which didn't look right on my screen! I also changed filtering such that it takes into account search and filters together (you had the filters only apply when the search bar is empty).
* beginning structure, wip * Filters mostly working now (except Category) Filters mostly working now (except Category) * removed commented code removed commented code * Implemented Filtering changes (except for categories) Implemented Filtering changes (except for categories) * removed api keys from server env * fixed filtering bugs after merging * added friendly names, fixed category filtering * partial checkin for search/filter change partial checkin for search/filter change * partial checkin...search bar implementation partial checkin...search bar implementation * now the old filtering works now the old filtering works * Searching by challenge name and location now work from search bar Searching by challenge name and location now work from search bar * Fixed issue with filters not filtering correctly Fixed issue with filters not filtering correctly * font * Filter UI changes * Now journeys also do filtering Now journeys also do filtering * search bar ui fixed * ran formatting commands * tab bar matches figma * fixed ui * minor changes * minor UI fixes and filter logic fixes --------- Co-authored-by: cathli66 <[email protected]> Co-authored-by: cathli66 <[email protected]>
Summary
This pull request is related to the filtering functionality of challenges/journeys. When a user selects certain filters on the filterForm, the search will result only displays events that match those filters.
Remaining TODOs:
Test Plan
filtering4.14.mov