Finish Gameplay #180
Merged
Finish Gameplay #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 1181. This diff might be too big! Developer leads are invited to review the code. |
|
Looks good. The documentation in the e2e testing is definitely useful. Adjustments to the UI seem to be standard and reflect the Figma changes well. Although I am wondering if the gameplay page is going to be redrawn/updated after the progress bar (circularIndicator) is returned, or generally how that loop is going to work? |
BrianLa0616
reviewed
Apr 15, 2024
…o gameplay-page Merging
…l-go into gameplay-page
neketka
requested changes
Apr 20, 2024
neketka
approved these changes
Apr 21, 2024
shah-esha
pushed a commit
that referenced
this pull request
Dec 4, 2024
* EventId instead of challengeId * Testing gameplay page and implemented updated UI changes * Documentation on challenge.e2e-spec.ts * Revert details page * Working on preview * working on challenge complete page * completing challenge page work * fixed setcurrentevent in preview * Challenges completed and journeys page frontend done * added more documentation to map * gameplay challenge flow complete * completed journey flow in gameplay * changed icon color, animated picture * added hints to backend - wip * implemented using hints in backend (untested) * hints fully connected * added prevchallengedto * final updates to hints in backend + gameplay page * fixed outdated usage of eventtrackerdto and indexing in completed cell * removed user arg from emitUpdateEventTracker * removed UseEventTrackerHintDto and fixed minor issues * fixed requested changes + admin frontend bugs * fixed formatting --------- Co-authored-by: cathli66 <[email protected]> Co-authored-by: cathli66 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is the implementing updated UI elements to match designers
This PR also finishes connecting gameplay to backend.
Breaking Changes
Updated database to include hintsUsed in EventTracker and PrevChallenge