-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google maps api integration #156
Conversation
[diff-counting] Significant lines: 561. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments about commented code + possible example code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran on my computer, looks good! I liked how you added comments and TODOs in the code. I can help test iOS with XCode on my end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that the maps do not work on iOS. Using GoogleMapsFlutterAndroid strictly in main.dart which might be a reason. Let me know when you fix this so I can test it on my simulator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested going into Google Maps from a challenge on IOS. Recentering worked so everything looks good!
* google maps api integration * gets current user location * fixed server format * Removed old code + documentation * added custom marker and test circle drawing * redirected details navigation from journey to nav bar * added recenter camera feature and two buttons on map (both currently recenter) * expanding challenge picture button * added flutter env file to store api keys, added key to iOS build file * adding dummy .env file so that remote branch will build * editing game/.gitignore to include .env file * Updated API key instructions for readme * check platform before setting Android map renderer * Small bug fix * fixed flutter formatting * minor changes to profile page overflow, set up navigation --------- Co-authored-by: Cathryn Li <[email protected]>
Summary
Integrating Google Maps API into CornellGo's app for our gameplay.
Does not include the Google Maps API key
Remaining TODOs:
Test Plan
Running on emulators or real devices. I need someone else to test iOS for me since I don't have XCode.
Notes
Does not include API key!! Reach out to me (through Slack) to get the API key when testing this PR.
Blockers