Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google maps api integration #156

Merged
merged 21 commits into from
Mar 12, 2024
Merged

google maps api integration #156

merged 21 commits into from
Mar 12, 2024

Conversation

cathli66
Copy link
Contributor

@cathli66 cathli66 commented Feb 22, 2024

Summary

Integrating Google Maps API into CornellGo's app for our gameplay.
Does not include the Google Maps API key

  • Updated Android and iOS build files to include Google Maps API class
  • Changed gameplay_map.dart from Flutter map (old) to Google Maps (new)
  • Tested Android Map SDK integration
  • Display and zoom to user's current location
  • Draw some random circle around a challenge for user testing
  • Move maps into gameplay page
  • Test Map SDK integration on iPhone

Remaining TODOs:

  • Connect with backend

Test Plan

Running on emulators or real devices. I need someone else to test iOS for me since I don't have XCode.

Notes

Does not include API key!! Reach out to me (through Slack) to get the API key when testing this PR.

Blockers

@dti-github-bot
Copy link
Member

dti-github-bot commented Feb 22, 2024

[diff-counting] Significant lines: 561.

Copy link
Collaborator

@neketka neketka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about commented code + possible example code

@cathli66 cathli66 requested a review from neketka February 26, 2024 22:48
Copy link
Contributor

@jasmineee-li jasmineee-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran on my computer, looks good! I liked how you added comments and TODOs in the code. I can help test iOS with XCode on my end.

Copy link
Contributor

@cgu2020 cgu2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that the maps do not work on iOS. Using GoogleMapsFlutterAndroid strictly in main.dart which might be a reason. Let me know when you fix this so I can test it on my simulator.

Copy link
Contributor

@3TTemi 3TTemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested going into Google Maps from a challenge on IOS. Recentering worked so everything looks good!

@cathli66 cathli66 dismissed neketka’s stale review March 12, 2024 23:11

Resolved requested changes

@cathli66 cathli66 merged commit 95621d9 into master Mar 12, 2024
10 checks passed
@cathli66 cathli66 deleted the cl893/gameplay-map branch March 12, 2024 23:11
shah-esha pushed a commit that referenced this pull request Dec 4, 2024
* google maps api integration

* gets current user location

* fixed server format

* Removed old code + documentation

* added custom marker and test circle drawing

* redirected details navigation from journey to nav bar

* added recenter camera feature and two buttons on map (both currently recenter)

* expanding challenge picture button

* added flutter env file to store api keys, added key to iOS build file

* adding dummy .env file so that remote branch will build

* editing game/.gitignore to include .env file

* Updated API key instructions for readme

* check platform before setting Android map renderer

* Small bug fix

* fixed flutter formatting

* minor changes to profile page overflow, set up navigation

---------

Co-authored-by: Cathryn Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants