Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish connecting journey's page to backend #137

Merged
merged 42 commits into from
Feb 23, 2024
Merged

Conversation

BrianLa0616
Copy link
Contributor

@BrianLa0616 BrianLa0616 commented Oct 8, 2023

Summary

Finishing connecting journey's page to backend

Remaining TODOs:

  • Test using frontend (events are currently not showing up)

Notes

Blockers

Breaking Changes

  • Database schema change (anything that changes TypeORM entities)
    Changed @relation(player) to (orgToUser)

@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 8, 2023

[diff-counting] Significant lines: 257.

@BrianLa0616 BrianLa0616 marked this pull request as draft October 8, 2023 00:50
Copy link
Contributor

@tuckerstanley tuckerstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good overall so far, a couple of comments though.

game/lib/journeys/journeys_page.dart Outdated Show resolved Hide resolved
game/lib/journeys/journeys_page.dart Outdated Show resolved Hide resolved
game/lib/journeys/journeys_page.dart Outdated Show resolved Hide resolved
@BrianLa0616 BrianLa0616 marked this pull request as ready for review November 27, 2023 23:32
Copy link
Contributor

@cgu2020 cgu2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to run the react server. It kept crashing after google login. My working branch was fine. I also couldn't see any data in the frontend maybe the backend was crashing/not populated.

cornell-go-postgres-1 | 2024-02-12 03:16:26.939 UTC [58] LOG: could not receive data from client: Connection reset by peer cornell-go-server-1 exited with code 0

Copy link
Collaborator

@neketka neketka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments related to clean code and some inconsistencies, but after those, this looks good to go. Good work!

game/lib/api/game_api.dart Outdated Show resolved Hide resolved
game/lib/api/game_api.dart Outdated Show resolved Hide resolved
game/lib/api/game_api.dart Outdated Show resolved Hide resolved
server/src/organization/organization.service.ts Outdated Show resolved Hide resolved
game/lib/journeys/journeys_page.dart Outdated Show resolved Hide resolved
game/lib/journeys/journeys_page.dart Outdated Show resolved Hide resolved
game/lib/journeys/journeys_page.dart Outdated Show resolved Hide resolved
game/lib/model/event_model.dart Outdated Show resolved Hide resolved
game/lib/model/event_model.dart Outdated Show resolved Hide resolved
Copy link
Collaborator

@neketka neketka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a couple of things left, but almost there!

game/lib/model/event_model.dart Show resolved Hide resolved
game/lib/api/game_api.dart Outdated Show resolved Hide resolved
game/lib/api/game_api.dart Outdated Show resolved Hide resolved
Copy link
Collaborator

@neketka neketka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything further is beyond the scope of this PR. I'm calling it done!

@BrianLa0616 BrianLa0616 merged commit ba6fd7a into master Feb 23, 2024
10 checks passed
@BrianLa0616 BrianLa0616 deleted the journeys_page branch February 23, 2024 16:31
shah-esha pushed a commit that referenced this pull request Dec 4, 2024
* added inital framework

* added data in journeys

* deleted

* Merged master with consumers

* Implemented flutter list *untested*

* Merge branch 'master' into journeys_page

* Working emulator

* Data properly fetched

* Got rid of debugging statements

* Duplicate events do not show

* CompletionRate and Difficulty added

* Reverted journeys page

* Weird change

* Hopefully final touches

* Tested

* Fully functional

* Remove user from upert

* Fixed bug

* Update gitignore

* Update pubspec and podfile

* google sign in

* Updated google sign in

* Widget properly updates

* removing outdated code

* Remove rewarded

* Resolve requested changes

* Enable geolocator

---------

Co-authored-by: Eric Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants