-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish connecting journey's page to backend #137
Conversation
[diff-counting] Significant lines: 257. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good overall so far, a couple of comments though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not able to run the react server. It kept crashing after google login. My working branch was fine. I also couldn't see any data in the frontend maybe the backend was crashing/not populated.
cornell-go-postgres-1 | 2024-02-12 03:16:26.939 UTC [58] LOG: could not receive data from client: Connection reset by peer cornell-go-server-1 exited with code 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments related to clean code and some inconsistencies, but after those, this looks good to go. Good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a couple of things left, but almost there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything further is beyond the scope of this PR. I'm calling it done!
* added inital framework * added data in journeys * deleted * Merged master with consumers * Implemented flutter list *untested* * Merge branch 'master' into journeys_page * Working emulator * Data properly fetched * Got rid of debugging statements * Duplicate events do not show * CompletionRate and Difficulty added * Reverted journeys page * Weird change * Hopefully final touches * Tested * Fully functional * Remove user from upert * Fixed bug * Update gitignore * Update pubspec and podfile * google sign in * Updated google sign in * Widget properly updates * removing outdated code * Remove rewarded * Resolve requested changes * Enable geolocator --------- Co-authored-by: Eric Huang <[email protected]>
Summary
Finishing connecting journey's page to backend
Remaining TODOs:
Notes
Blockers
Breaking Changes
Changed @relation(player) to (orgToUser)