-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Landing Page #538
New Landing Page #538
Conversation
[diff-counting] Significant lines: 268. |
Great work implementing the landing page! Small things to note, I know this is a work in progress, but just be sure to remove the comments when you're done for better readability. For the resizing, since you said it was problematic, maybe consider using CSS Flexbox or Grid, or media queries, ie. |
…into rj353/landing_page
- Brought back old landing page - Included wave svg - Clickable TOS button and DTI logo
…into rj353/landing_page
…into rj353/landing_page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty good PR. You did a great job we've been in need of a new landing page for sometime and this looks pretty good.
Your code follows proper convention and there aren't any bugs after running on different browsers. Like the responsiveness.
We can add a media query to support smaller devices for responsivity in a later PR. Great Job
Summary
This PR is an implementation of a responsive Carriage landing page.
Future work may include:
Test Plan
There are not any unit tests I executed as the code is front-end heavy and mainly just styling. Here is the demo:
Screen.Recording.2024-10-27.at.10.54.55.PM.mov
Breaking Changes
Prettier check is failing