Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Landing Page #538

Merged
merged 17 commits into from
Nov 11, 2024
Merged

New Landing Page #538

merged 17 commits into from
Nov 11, 2024

Conversation

raissaji
Copy link
Contributor

@raissaji raissaji commented Oct 14, 2024

Summary

This PR is an implementation of a responsive Carriage landing page.
Future work may include:

  • More aesthetic design from future designer. This can include a description of Carriage (like a slogan) and its partnership with CuLift
  • Payload for email signup for new users
  • Vertical media queries

Test Plan

There are not any unit tests I executed as the code is front-end heavy and mainly just styling. Here is the demo:

Screen.Recording.2024-10-27.at.10.54.55.PM.mov

Breaking Changes

Prettier check is failing

@raissaji raissaji requested a review from a team as a code owner October 14, 2024 01:35
@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 14, 2024

[diff-counting] Significant lines: 268.

@selenaliu1
Copy link
Contributor

Great work implementing the landing page! Small things to note, I know this is a work in progress, but just be sure to remove the comments when you're done for better readability. For the resizing, since you said it was problematic, maybe consider using CSS Flexbox or Grid, or media queries, ie.
@media(max-width: 768px) { .container_item_left, .container_item_right { flex-direction: column; } }

@raissaji raissaji changed the title WIP of Implementing New Landing Page Implementing New Landing Page Oct 27, 2024
@raissaji raissaji changed the title Implementing New Landing Page New Landing Page Oct 28, 2024
Copy link
Collaborator

@Atikpui007 Atikpui007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty good PR. You did a great job we've been in need of a new landing page for sometime and this looks pretty good.

Your code follows proper convention and there aren't any bugs after running on different browsers. Like the responsiveness.

We can add a media query to support smaller devices for responsivity in a later PR. Great Job

@Atikpui007 Atikpui007 merged commit a1bf070 into master Nov 11, 2024
5 checks passed
@Atikpui007 Atikpui007 deleted the rj353/landing_page branch November 11, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants