Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student address requirements #501

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+10 −2
Open

Student address requirements #501

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8bf6d19
Removed address parsing
raissaji Mar 13, 2024
36c7340
Deleted commented-out code
raissaji Mar 13, 2024
3be3038
Use regex for address validation and re-added isAddress check
raissaji Sep 23, 2024
edf999c
Add documentation to address validation logic
raissaji Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Deleted commented-out code
@raissaji
raissaji committed Mar 13, 2024

Unverified

No user is associated with the committer email.
Learn about vigilant mode
commit 36c73408fcf5f183533e5c79fe3a67d8aaa329be
22 changes: 0 additions & 22 deletions server/src/util/index.ts
View file
Original file line number Diff line number Diff line change
@@ -11,28 +11,6 @@ export function createKeys(property: string, values: string[]) {
}

export function isAddress(address: string) {
// let parsedAddr;
// try {
// parsedAddr = parseAddress(address);
// } catch {
// return false;
// }
// const {
// streetNumber,
// streetName,
// streetSuffix,
// placeName,
// stateName,
// zipCode,
// } = parsedAddr;
// return Boolean(
// streetNumber &&
// streetName &&
// streetSuffix &&
// placeName &&
// stateName &&
// zipCode
// );
return true;
}

Unchanged files with check annotations Beta

View file
frontend/src/components/AuthManager/AuthManager.tsx
import {
useGoogleLogin as googleAuth,
googleLogout,
TokenResponse,

Check warning on line 5 in frontend/src/components/AuthManager/AuthManager.tsx

GitHub Actions / check 

'TokenResponse' is defined but never used
} from '@react-oauth/google';
import {
useHistory,
import AuthContext from '../../context/auth';
import LandingPage from '../../pages/Landing/Landing';
import Home from '../../pages/Admin/Home';

Check warning on line 18 in frontend/src/components/AuthManager/AuthManager.tsx

GitHub Actions / check 

'Home' is defined but never used
import styles from './authmanager.module.css';
import { googleLogin } from '../../icons/other';
import SubscribeWrapper from './SubscrbeWrapper';
}
}
function createRefresh(userId: string, userType: string, token: string) {

Check warning on line 165 in frontend/src/components/AuthManager/AuthManager.tsx

GitHub Actions / check 

'token' is defined but never used
const endpoint =
userType === 'Admin' ? `/api/admins/${userId}` : `/api/riders/${userId}`;
return () => {
View file
frontend/src/components/AuthManager/SubscrbeWrapper.tsx
import React, { useState, useEffect, ReactFragment, ReactElement } from 'react';

Check warning on line 1 in frontend/src/components/AuthManager/SubscrbeWrapper.tsx

GitHub Actions / check 

'ReactFragment' is defined but never used
import subscribeUser from './subscribeUser';
interface Props {
View file
frontend/src/components/AuthManager/subscribeUser.ts
process.env.REACT_APP_PUBLIC_VAPID_KEY!
);
type WithDefaultsType = (options?: RequestInit) => RequestInit;

Check warning on line 20 in frontend/src/components/AuthManager/subscribeUser.ts

GitHub Actions / check 

'WithDefaultsType' is defined but never used
const sendSubscription = (
userType: string,
// 'New subscription added.'
sendSubscription(userType, userId, newSubscription);
})
.catch((e) => {

Check warning on line 59 in frontend/src/components/AuthManager/subscribeUser.ts

GitHub Actions / check 

'e' is defined but never used
if (Notification.permission !== 'granted') {
// 'Permission was not granted.'
}
}
});
})
.catch((e) => {

Check warning on line 71 in frontend/src/components/AuthManager/subscribeUser.ts

GitHub Actions / check 

'e' is defined but never used
// 'An error ocurred during Service Worker registration.'
});
}
View file
frontend/src/components/CopyButton/CopyButton.tsx
import React, { useState } from 'react';

Check warning on line 1 in frontend/src/components/CopyButton/CopyButton.tsx

GitHub Actions / check 

'useState' is defined but never used
import { Button } from '../FormElements/FormElements';
import { useRiders } from '../../context/RidersContext';
import styles from './copyButton.module.css';
View file
frontend/src/components/EmployeeCards/EmployeeCards.tsx
import React, { useState, useMemo } from 'react';

Check warning on line 1 in frontend/src/components/EmployeeCards/EmployeeCards.tsx

GitHub Actions / check 

'useState' is defined but never used
import { Link, useParams } from 'react-router-dom';

Check warning on line 2 in frontend/src/components/EmployeeCards/EmployeeCards.tsx

GitHub Actions / check 

'useParams' is defined but never used
import Card, { CardInfo } from '../Card/Card';
import styles from './employeecards.module.css';
import { clock, phone, wheel, user } from '../../icons/userInfo/index';