Kl628/inactive-student-display #483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 22. |
kevin-lin12
changed the title
CollinWoo
reviewed
Dec 4, 2023
| Show inactive students | ||
| </label> | ||
| <button | ||
| type="button" |
There was a problem hiding this comment.
I think you can omit type="button" here since the button tag already indicates that this element is a button. This shouldn't affect any of the functionality.
| @@ -45,4 +45,4 @@ | |||
| "url": "https://github.com/cornell-dti/carriage-web/issues" | |||
There was a problem hiding this comment.
I assume that these changes to package.json and package-lock.json were unintentional. To make git ignore local changes to these files in the future, you can run git update-index --skip-worktree package-lock.json package.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes the display for Inactive students and changes the button to a toggle
Trello Link:
https://trello.com/c/MuY5PHBE/504-active-students-toggle
Test Plan
Style Changes
Before
After
Before Clicking Button
After Clicking Button
Notes
(12/3) Committed Button Style Change
Breaking Changes