Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving Voice Over issues with Links on Sidebar #474

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

pratyush1712
Copy link
Member

@pratyush1712 pratyush1712 commented Oct 24, 2023

Summary

Home-Sidebar links
  • Reorganized usage of aria tags to prevent voice-over from announcing the link twice.
  • Added documentation for the truncate function used to shorten the notification message in the Message.tsx component.

@pratyush1712 pratyush1712 requested a review from a team as a code owner October 24, 2023 22:16
@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 24, 2023

[diff-counting] Significant lines: 101.

Copy link
Collaborator

@Atikpui007 Atikpui007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well
Old PR that needs merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants