Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by API group and consider all subresources in resource view, and respect API group in subject view #177

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

luxas
Copy link

@luxas luxas commented Aug 23, 2024

Hi 👋 ! Thanks a lot for this project!

Here's a couple of improvements (at least in my opinion, let me know what you think 😄) to the project:

  • Text output in resource view is now sorted by API group, so it's easier for a human reviewer of the output to look at similar resources together. Also it is easier to read what the name of the resource is when the api group name is not duplicated for every resource.
  • Previously, subresources like /status and /scale, or importantly serviceaccounts/token or certificatesigningrequests/approval, were not listed. By looking up all resources within a groupversion, we now include this data in the output.
  • API group was not taken into account in the subject view, which means that if there was an RBAC rule that gave a user access to deployments.mycustomgroup, it would look like that user also had access to deployments.apps

Let me know what you think about these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant