fix: correct score calculation in getDailyOverview function #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the score calculation logic in the getDailyOverview function to subtract the scores of the winning teams instead of adding them. This change ensures that the scoring reflects the intended game mechanics and provides accurate game summaries.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Title: fix: correct score calculation in getDailyOverview function
Description:
This pull request addresses an issue with the score calculation in the
getDailyOverviewfunction. The logic has been updated to subtract the scores of the winning teams rather than adding them. This adjustment is crucial for ensuring that the scoring accurately reflects the intended game mechanics, leading to more precise game summaries.Changes Made:
getDailyOverviewfunction.This change is expected to enhance the accuracy of the game summaries and improve the overall functionality of the scoring system.