Skip to content

Tempfs new

Tempfs new #188

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / clippy succeeded Nov 27, 2023 in 0s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.76.0-nightly (6cf088810 2023-11-26)
  • cargo 1.76.0-nightly (9b13310ca 2023-11-24)
  • clippy 0.1.76 (6cf0888 2023-11-26)

Annotations

Check warning on line 154 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `LinearFramebuffer` which implements the `Copy` trait

warning: using `clone` on type `LinearFramebuffer` which implements the `Copy` trait
   --> src/main.rs:154:27
    |
154 |     let mut framebuffer = boot_info.framebuffer.clone();
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `boot_info.framebuffer`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `#[warn(clippy::clone_on_copy)]` on by default

Check warning on line 104 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this operation has no effect

warning: this operation has no effect
   --> src/main.rs:104:44
    |
104 |     let init_alloc_size = HumanBytes::from(1 * HumanBytes::MIB) - 2.into();
    |                                            ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `HumanBytes::MIB`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
    = note: `#[warn(clippy::identity_op)]` on by default

Check warning on line 52 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this import is redundant

warning: this import is redundant
  --> src/main.rs:52:1
   |
52 | use fs;
   | ^^^^^^^ help: remove it entirely
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
   = note: `#[warn(clippy::single_component_path_imports)]` on by default

Check warning on line 130 in src/clock/rtc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of an assign operation

warning: manual implementation of an assign operation
   --> src/clock/rtc.rs:130:9
    |
130 |         current_rtc_time.hour = current_rtc_time.hour % 24;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_rtc_time.hour %= 24`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
    = note: `#[warn(clippy::assign_op_pattern)]` on by default

Check warning on line 64 in src/clock/rtc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you should consider adding a `Default` implementation for `RealTimeClock`

warning: you should consider adding a `Default` implementation for `RealTimeClock`
  --> src/clock/rtc.rs:59:5
   |
59 | /     pub fn new() -> Self {
60 | |         Self {
61 | |             time: Time::new(),
62 | |             time_zone_modification: 0,
63 | |         }
64 | |     }
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
   = note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
   |
55 + impl Default for RealTimeClock {
56 +     fn default() -> Self {
57 +         Self::new()
58 +     }
59 + }
   |